Created on 2012-09-07 18:56 by mcdonc, last changed 2012-09-13 16:28 by python-dev.
Files | ||||
---|---|---|---|---|
File name | Uploaded | Description | Edit | |
shutdown_typeerror-tip.patch | mcdonc, 2012-09-07 19:15 | review | ||
shutdown_typeerror-27.patch | mcdonc, 2012-09-07 19:23 | review |
Messages (14) | |||
---|---|---|---|
msg170003 - (view) | Author: Chris McDonough (mcdonc) | Date: 2012-09-07 18:56 | |
The symptom is an exact duplicate of the symptom reported in the following (closed) issue: bugs.python.org/issue9775 The issue is also related to the following other issues: bugs.python.org/issue4106 bugs.python.org/issue9205 bugs.python.org/issue9207 To reproduce the symptom driving the patches that will be attached to this issue: git clone git://github.com/pypa/pip.git cd pip /any/python setup.py dev /any/python setup.py test You can either wait for the entire test suite to finish or you can press ctrl-C at any time (the tests take a long time). In either case, a traceback like the following will be printed to the console. Error in atexit._run_exitfuncs: Traceback (most recent call last): File "/home/chrism/opt/Python-2.7.3/lib/python2.7/atexit.py", line 24, in _run_exitfuncs func(*targs, **kargs) File "/home/chrism/opt/Python-2.7.3/lib/python2.7/multiprocessing/util.py", line 284, in _exit_function info('process shutting down') TypeError: 'NoneType' object is not callable Error in sys.exitfunc: Traceback (most recent call last): File "/home/chrism/opt/Python-2.7.3/lib/python2.7/atexit.py", line 24, in _run_exitfuncs func(*targs, **kargs) File "/home/chrism/opt/Python-2.7.3/lib/python2.7/multiprocessing/util.py", line 284, in _exit_function info('process shutting down') TypeError: 'NoneType' object is not callable From what I understand in other issues, multiprocessing.util._exit_function shouldn't actually be called *after* the containing module's globals are destroyed (it should be called before), but this does indeed happen. Patches will be attached that anticipate the symptom and prevent a shutdown error. One will be attached for Python 2.7 branch, the other for the Python tip. Each causes functions that are called at shutdown time to keep a reference around to other functions and globals used within the function, and each does some checks for the insane state and prevents an error from happening in this insane state. |
|||
msg170008 - (view) | Author: Chris McDonough (mcdonc) | Date: 2012-09-07 19:15 | |
Patch for tip. |
|||
msg170009 - (view) | Author: Chris McDonough (mcdonc) | Date: 2012-09-07 19:23 | |
2.7 branch patch. |
|||
msg170022 - (view) | Author: Alexander Belopolsky (belopolsky) * ![]() |
Date: 2012-09-08 04:24 | |
The patch makes sense. I'll take another look over the weekend, but it seems to be ready to be applied. |
|||
msg170023 - (view) | Author: Chris Jerdonek (chris.jerdonek) * ![]() |
Date: 2012-09-08 05:21 | |
+ # NB: we hold on to references to functions in the arglist due to the This is a nit, but I think adding "NB:", "Note:", etc. to the beginning of a comment is redundant because by being a comment it is already implicit that it should be noted. |
|||
msg170119 - (view) | Author: Roundup Robot (python-dev) | Date: 2012-09-09 17:28 | |
New changeset 27d410dd5431 by Alexander Belopolsky in branch '3.2': Issue #15881: Fixed atexit hook in multiprocessing. hg.python.org/cpython/rev/27d410dd5431 New changeset 08c680918ff8 by Alexander Belopolsky in branch 'default': Issue #15881: Fixed atexit hook in multiprocessing. hg.python.org/cpython/rev/08c680918ff8 |
|||
msg170120 - (view) | Author: Roundup Robot (python-dev) | Date: 2012-09-09 17:31 | |
New changeset db67b848ddc3 by Alexander Belopolsky in branch '3.2': Issue #15881: Fixed 3.2 backport. hg.python.org/cpython/rev/db67b848ddc3 |
|||
msg170121 - (view) | Author: Alexander Belopolsky (belopolsky) * ![]() |
Date: 2012-09-09 17:55 | |
Applied to 3.2 and 3.3. Thanks for the patch! Leaving it open pending 2.7 commit. |
|||
msg170122 - (view) | Author: Roundup Robot (python-dev) | Date: 2012-09-09 18:12 | |
New changeset b05547e8ff92 by Alexander Belopolsky in branch '3.2': Issue #15881: Added NEWS entry and proper credit. hg.python.org/cpython/rev/b05547e8ff92 |
|||
msg170187 - (view) | Author: Richard Oudkerk (sbt) * ![]() |
Date: 2012-09-10 13:07 | |
I see the same error on Windows (when pressing ^C), but on Linux I get Error in sys.exitfunc: Traceback (most recent call last): File "/usr/lib/python2.7/atexit.py", line 28, in _run_exitfuncs import traceback File "/usr/lib/python2.7/traceback.py", line 3, in <module> import linecache File "/usr/lib/python2.7/linecache.py", line 9, in <module> import os File "/usr/lib/python2.7/os.py", line 119, in <module> sys.modules['os.path'] = path AttributeError: 'module' object has no attribute 'modules' This also suggests that module teardown has begun before/while sys.exitfunc is running. |
|||
msg170215 - (view) | Author: Richard Oudkerk (sbt) * ![]() |
Date: 2012-09-10 18:41 | |
I suspect the problem is caused by nose's isolate plugin. With this enabled, a copy of sys.modules is saved before each test and then restored after the test. This causes garbage collection of newly imported modules. The destructor for the module type causes all globals to be replaced by None. This will break the atexit function registered by multiprocessing since it depends on globals. PS. A simple work-around (which does not require people to upgrade to a bugfixed version of Python) is to put try: import multiprocessing except ImportError: pass near the beginning of setup.py. After this change I don't get the error when running "python setup.py test". |
|||
msg170220 - (view) | Author: Richard Oudkerk (sbt) * ![]() |
Date: 2012-09-10 19:23 | |
Actually, I am not so sure it is the isolate plugin. But I do think that sys.modules is being manipulated somewhere before shutdown. |
|||
msg170230 - (view) | Author: Richard Oudkerk (sbt) * ![]() |
Date: 2012-09-10 20:22 | |
Actually it is test.with_project_on_sys_path() in setuptools/commands/test.py that does the save/restore of sys.modules. See www.eby-sarna.com/pipermail/peak/2010-May/003357.html |
|||
msg170446 - (view) | Author: Roundup Robot (python-dev) | Date: 2012-09-13 16:28 | |
New changeset 2b79b4848f44 by Richard Oudkerk in branch 'default': Issue #15881: Clarify comment in exit function hg.python.org/cpython/rev/2b79b4848f44 |
History | |||
---|---|---|---|
Date | User | Action | Args |
2012-09-13 16:28:17 | python-dev | set | messages: + msg170446 |
2012-09-12 08:48:37 | mitar | set | nosy:
+ mitar |
2012-09-10 22:41:46 | Arfrever | set | nosy:
+ Arfrever |
2012-09-10 20:22:45 | sbt | set | messages: + msg170230 |
2012-09-10 19:23:33 | sbt | set | messages: + msg170220 |
2012-09-10 18:41:46 | sbt | set | messages: + msg170215 |
2012-09-10 13:07:59 | sbt | set | messages: + msg170187 |
2012-09-09 18:12:01 | python-dev | set | messages: + msg170122 |
2012-09-09 17:55:39 | belopolsky | set | resolution: fixed messages: + msg170121 stage: commit review -> committed/rejected |
2012-09-09 17:31:20 | python-dev | set | messages: + msg170120 |
2012-09-09 17:28:06 | python-dev | set | nosy:
+ python-dev messages: + msg170119 |
2012-09-08 05:21:30 | chris.jerdonek | set | nosy:
+ chris.jerdonek messages: + msg170023 |
2012-09-08 04:24:28 | belopolsky | set | nosy:
+ belopolsky messages: + msg170022 assignee: belopolsky stage: patch review -> commit review |
2012-09-07 19:40:11 | mark.dickinson | set | stage: patch review versions: - Python 2.6, Python 3.1 |
2012-09-07 19:23:27 | mcdonc | set | files:
+ shutdown_typeerror-27.patch messages: + msg170009 |
2012-09-07 19:15:56 | mcdonc | set | files:
+ shutdown_typeerror-tip.patch keywords: + patch messages: + msg170008 |
2012-09-07 19:13:35 | sbt | set | nosy:
+ sbt |
2012-09-07 18:56:39 | mcdonc | create |